Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix description for credentials provider #9731

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

kdnakt
Copy link
Contributor

@kdnakt kdnakt commented Jun 2, 2020

Fixed AWS credentials info according to the official document:
https://docs.aws.amazon.com/sdk-for-java/v2/developer-guide/credentials.html

@gsmet
Copy link
Member

gsmet commented Jun 2, 2020

@marcinczeczko could you have a look at that one?

@sberyozkin
Copy link
Member

Is there an option (in the future) to have these AWS features exposed to the rest of Quarkus via a new credential provider spi ?

@marcinczeczko
Copy link
Contributor

@kdnakt thanks for spotting it up. @gsmet looks good to me

@kdnakt
Copy link
Contributor Author

kdnakt commented Jun 4, 2020

Thank you for the review!

@marcinczeczko
Copy link
Contributor

@sberyozkin - I think it might be a good idea. Are you able to raise an issue and describe come potential scenarios where you'd like to use it ?

@gsmet gsmet merged commit 74ed836 into quarkusio:master Jun 10, 2020
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 10, 2020
@gsmet gsmet modified the milestones: 1.6.0 - master, 1.5.1.Final Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants