Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubernetesDeploy update to always close client and to fetch masterURL just once #9827

Merged
merged 1 commit into from
Jun 5, 2020
Merged

KubernetesDeploy update to always close client and to fetch masterURL just once #9827

merged 1 commit into from
Jun 5, 2020

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Jun 5, 2020

KubernetesDeploy update to always close client and to fetch masterURL just once

Client wasn't closed in case if (version == null)

masterURL = client.getConfiguration().getMasterUrl(); was called twice (line 68 and 70)

@rsvoboda rsvoboda requested a review from geoand June 5, 2020 13:19
geoand
geoand approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@geoand geoand merged commit 507ce3e into quarkusio:master Jun 5, 2020
@geoand geoand added this to the 1.6.0 - master milestone Jun 5, 2020
@rsvoboda rsvoboda deleted the KubernetesDeploy.client branch March 4, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/kubernetes
Projects
None yet
Milestone
1.6.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@rsvoboda @geoand