Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First step to extract Maven-specific parts from the bootstrap core #9828

Merged
merged 1 commit into from
Jun 9, 2020
Merged

First step to extract Maven-specific parts from the bootstrap core #9828

merged 1 commit into from
Jun 9, 2020

Conversation

aloubyansky
Copy link
Member

@aloubyansky aloubyansky commented Jun 5, 2020 •
edited
Loading

This PR extracts the following from quarkus-bootstrap-core:

  • AppModel API to quarkus-bootstrap-app-model module;
  • the Maven resolver impl to quarkus-bootstrap-maven-resolver module (this one depends on app-model).

quarkus-bootstrap-core now depends on

  • quarkus-bootstrap-app-model;
  • and still on quarkus-bootstrap-maven-resolver at this point, so anything that depends on quarkus-bootstrap-core will still work w/o adding extra dependencies.

The Gradle plugin depends on:

  • quarkus-bootstrap-core and excludes quarkus-bootstrap-maven-resolver

@boring-cyborg boring-cyborg bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels Jun 5, 2020
@aloubyansky aloubyansky force-pushed the bootstrap-core-split branch 5 times, most recently from f0a8c6a to f100992 Compare June 6, 2020 06:06
@aloubyansky
Copy link
Member Author

I also included a few interfaces in app-model module package io.quarkus.bootstrap.resolver.workspace as a start to represent the Maven and Gradle projects from a workspace.

@aloubyansky aloubyansky mentioned this pull request Jun 8, 2020
Closed
@aloubyansky aloubyansky force-pushed the bootstrap-core-split branch from f100992 to 5ce695a Compare June 8, 2020 15:57
@boring-cyborg boring-cyborg bot added the area/gradle Gradle label Jun 8, 2020
stuartwdouglas
stuartwdouglas requested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@stuartwdouglas stuartwdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the extra file.

@aloubyansky aloubyansky force-pushed the bootstrap-core-split branch from 5ce695a to c4d88a3 Compare June 9, 2020 04:20
@aloubyansky aloubyansky force-pushed the bootstrap-core-split branch from c4d88a3 to ae8f476 Compare June 9, 2020 04:33
@aloubyansky aloubyansky merged commit 7e608a2 into quarkusio:master Jun 9, 2020
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Assignees
No one assigned
Labels
area/bootstrap area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/maven
Projects
None yet
Milestone
1.6.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@aloubyansky @stuartwdouglas @gsmet