Fix trustStore handling in native-image #9906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
changed the title
geoand
changed the title
|
@gsmet I added a test case, which is slightly ugly, but I think is useful in preventing the change in behavior in GraalVM that we never caught. What is missing from this PR is doc update, but I'll wait until we take more about this before making those changes. |
geoand
force-pushed
the
#9713
branch
3 times, most recently
from
cf4eee1 to
d0555a9
Compare
|
Ah.. the new test fails because of Docker... I need to see if / how this can be fixed |
|
The test actually uncovered an issue that was fixed 😎 |
gsmet
reviewed
Jun 15, 2020
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Guillaume Smet <[email protected]>
Thanks for the thorough review! The comments have been addressed |
gsmet
approved these changes
Jun 15, 2020
gsmet
added
the
triage/waiting-for-ci
|
@gsmet this isn't a notable feature, but I think that it should be mentioned in the release somehow, WDYT? |
|
Agreed, I had the same idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9713
This is a draft for now since there is a lot more that needs to be done (our handling of the trustStore seems to be at odds with what GraalVM native-image does).