Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move google-cloud-functions-http tests into profile activated on JDK 11+ #9908

Closed
wants to merge 1 commit into from
Closed

Move google-cloud-functions-http tests into profile activated on JDK 11+ #9908

wants to merge 1 commit into from

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Jun 10, 2020 •
edited by geoand
Loading

Move google-cloud-functions-http tests into profile activated on JDK 11+

Currently there are several workarounds on CI level and users can't build Quarkus master on JDK8 using simple mvn clean install approach.

Fixes: #9904

@boring-cyborg boring-cyborg bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jun 10, 2020
geoand
geoand approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gemmellr
Copy link
Contributor

I have the same change prepared and runnning tests before raising, but I dont think its the correct change now: #9904 (comment)

@rsvoboda
Copy link
Member Author

I'm introducing new profile in integration-tests/pom.xml, it won't have any impact on release build or procedure.

@gemmellr
Copy link
Contributor

I guess it depends on how the release is done. I dont know the processes for Quarkus, but it would certainly affect how I do releases of other things. By disabling the module on 8, which the releases are done using (so far), it would mean any plugins etc used to update verisons wont run for that module. If that is how the versions are usually updated, then the module would either have a stale version (due to not being updated) or need manually adjusted to ensure it didnt.

@gemmellr gemmellr mentioned this pull request Jun 10, 2020
Merged
@gemmellr
Copy link
Contributor

I raised an alternative PR #9912, it just makes the module compile with 8 since it seems it already can.

@gemmellr gemmellr mentioned this pull request Jun 10, 2020
Closed
@geoand
Copy link
Contributor

geoand commented Jun 11, 2020

I merged #9912 so I'll close this for now. We can reexamine if needed.

@geoand geoand closed this Jun 11, 2020
@gsmet gsmet added the triage/invalid This doesn't seem right label Jun 11, 2020
@rsvoboda rsvoboda deleted the jdk11plus branch March 4, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure triage/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Java 11 only integration tests handling
4 participants
@rsvoboda @gemmellr @geoand @gsmet