Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Maven-based AppModelResolver impl to quarkus-bootstrap-maven-resolver #9923

Conversation

aloubyansky
Copy link
Member

  • moving the BootstrapAppModelResolver to the quarkus-bootstrap-maven-resolver
  • add quarkus-bootstrap-app-model and quarkus-bootstrap-maven-resolver to the deployment bom
  • register org.codehaus.plexus:plexus-utils as parent-first for our classloading (this one is needed for code.quarkus.io)

cc @ia3andy with this change I could go through your testsuite (there were other failures but they looked like having a different cause).

@boring-cyborg boring-cyborg bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/kotlin area/platform Issues related to definition and interaction with Quarkus Platform area/scala labels Jun 10, 2020
@aloubyansky
Copy link
Member Author

BTW, I am not entirely happy/done with extracting Maven-based app model resolution bits from quarkus-bootstrap-core. E.g. BootstrapAppModelResolverFactory still remains in quarkus-bootstrap-core.

@aloubyansky aloubyansky force-pushed the move-maven-app-model-resolver-to-maven-resolver branch from 6e06b4b to 124a512 Compare June 10, 2020 21:07
@aloubyansky aloubyansky merged commit 1d45691 into quarkusio:master Jun 11, 2020
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/kotlin area/platform Issues related to definition and interaction with Quarkus Platform area/scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants