Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to keycloak-authorization docs and lower case for enum properties #9972

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

pedroigor
Copy link
Contributor

@pedroigor pedroigor commented Jun 12, 2020

fixes #8469

@pedroigor
Copy link
Contributor Author

@gsmet Could you please take a look at my change to the io.quarkus.annotation.processor.generate_doc.DocGeneratorUtil#joinAcceptedValues method and see if it makes sense?

From your comment here #9583, you suggested to use lowercase for default values. However other properties like this one is not generated using lowercase. Only a top level property like this other one is.

@Ladicek
Copy link
Contributor

Ladicek commented Jun 15, 2020

The documentation change here looks good. I don't know enough about Quarkus config system to comment on the rest :-)

@gsmet gsmet merged commit 86d4ff0 into quarkusio:master Jun 17, 2020
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 17, 2020
@gsmet gsmet changed the title [fixes #8469] - Minor changes to keycloak-authorization docs and lower case for enum properties Minor changes to keycloak-authorization docs and lower case for enum properties Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation for Keycloak authorization is insufficient
3 participants