Use getHost instead of getContainerIpAddress #1431
Conversation
getContainerIpAddress is deprecated
|
Hi @eddumelendez . Thanks for this but changes to the guides need to be done there: https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc . Once it's in the main repo, I'll merge your PR though as fixing old branches is a good idea. |
|
Hi @gsmet, I submitted quarkusio/quarkus#25584 and it was merged already |
|
Sorry I missed it. I'll wait for CI and merge. Thanks! |
| @@ -613,7 +613,7 @@ public class KafkaAndSchemaRegistryTestResource implements QuarkusTestResourceLi | |||
| registry.start(); | |||
| Map<String, String> properties = new HashMap<>(); | |||
| properties.put("mp.messaging.connector.smallrye-kafka.apicurio.registry.url", | |||
| "http://" + registry.getContainerIpAddress() + ":" + registry.getMappedPort(8080) + "/apis/registry/v2"); | |||
| "http://" + registry.getHost() + ":" + registry.getMappedPort(8080) + "/apis/registry/v2"); | |||
There was a problem hiding this comment.
Just to be sure: have you checked if this method is already there in the version of Testcontainers used in 2.2?
There was a problem hiding this comment.
quarkus 2.2 uses testcontainers 1.15.3 as you can see here and getHost is available is that version https://github.com/testcontainers/testcontainers-java/blob/1.15.3/core/src/main/java/org/testcontainers/containers/ContainerState.java#L58-L61
|
Merged, thanks! |
getContainerIpAddress is deprecated