Feature/network refactor #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
commented
Jan 20, 2022
ryan-summers
commented
Jan 21, 2022
|
@jordens Would you mind taking a quick look after refactor to support the ENC424J600 as well? I had to redo the |
jordens
requested changes
Jan 21, 2022
ryan-summers
force-pushed
the
feature/network-refactor
branch
from
288f6cd to
aa1d0b1
Compare
|
ENC424J600 has been removed, as we do not have the capabilities to test these changes. Instead, the build will remain broken for this variant with WIP implementation on |
jordens
approved these changes
Jan 24, 2022
|
We should allow enc24 CI to fail though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Boosternetwork into anetfolder, implements a shared network stack, and updates theminimqclient version to 0.5.2 so we can leverage various bug fixes and improvements.I've also added in a
SystemTimerto track longer time durations and replaced theEpochClockthat was used for the smoltcp implementation previously, as that timer was only able to track short time durations.