Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating usb-device dependency #226

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Updating usb-device dependency #226

merged 1 commit into from
Jun 3, 2022

Conversation

ryan-summers
Copy link
Member

@ryan-summers ryan-summers commented Jun 3, 2022 •
edited
Loading

This PR fixes #224 by updating the usb-device dependency.

  • The Basic HITL test script was executed against this change to verify the device behaves normally.
  • I also connected USB to verify everything worked as expected.

@ryan-summers ryan-summers requested a review from jordens June 3, 2022 14:16
jordens
jordens reviewed Jun 3, 2022
View reviewed changes
Cargo.toml Show resolved Hide resolved
jordens
jordens approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I'll leave the choice of rev or not to you.

@ryan-summers ryan-summers merged commit fb49044 into develop Jun 3, 2022
@ryan-summers ryan-summers deleted the rs/issue-224/usb-device-dep branch June 3, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordens jordens jordens approved these changes

Assignees

@jordens jordens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

usb-device dependency no longer exists
2 participants
@ryan-summers @jordens