Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Booster v1.6 channels #237

Merged
merged 6 commits into from
Apr 5, 2023

Conversation

ryan-summers
Copy link
Member

@ryan-summers ryan-summers commented Oct 10, 2022

This PR fixes #233 by adding an additional ON/OFF toggle during the channel initial power-up.

It's not currently known if this is sufficient to clear the interlocks in all cases because of the unknown states of the power detectors during the power-up process. If the power detectors create transient voltage outputs that exceed the interlock thresholds, the channels will power up in a tripped state.

However, the most likely case is that the power detectors will remain low during the power-on process and the interlock will not trip, so there's relatively high confidence that this should address v1.6 concerns.

It was discovered that the power detectors did not stay low during initialization, but this was remedied by resetting the interlocks immediately after the channel powered up.

@ras14k
Copy link

ras14k commented Jan 2, 2023

TESTED ON BOOSTER HL v1.6
{
"firmware_version": "v0.4.0-16-g343e7a9",
"rust_version": "rustc 1.62.1 (e092d0b6b 2022-07-16)",
"profile": "release",
"git_dirty": false,
"features": "DEFAULT, PHY_W5500, W5500",
"panic_info": "None",
"watchdog": false,
"hardware_version": "Unknown (0b101)"
}

input_power = -25 dBm
expected output_power = +8 dBm
output_interlock_threshold = +20.0 dBm
action: changing channel state from "Off" to "Enabled"
action: clearing interlock with a button
action: saving configuration to EEPROM
action: power off Booster for 1 minute
action: power on Booster
result: channel is enabled but interlock is tripped (can be reset with a button)

jordens and others added 2 commits April 5, 2023 17:29
…v1.6-support

* origin/main: (78 commits)
  Updating changelog
  Adding detected phy to service info
  Updating workflow
  Fixing detection algorithm
  Adding basic phy detection
  Adding token
  Removing deploy key
  Updating trigger branches for docs
  Updating booster docs location
  Removing W5500 patch
  Simplifying watchdog timer types
  Updating HAL and other dependencies
  Bump serde from 1.0.157 to 1.0.158
  Bump serde from 1.0.156 to 1.0.157
  Bump serde from 1.0.155 to 1.0.156
  Bump serde from 1.0.152 to 1.0.155
  Bump enum-iterator from 1.3.0 to 1.4.0
  Bump cortex-m-rtic from 1.1.3 to 1.1.4
  Bump cortex-m-log from 0.7.0 to 0.8.0
  Bump bit_field from 0.10.1 to 0.10.2
  ...
@ryan-summers ryan-summers changed the base branch from main to feature/bors-support April 5, 2023 16:55
@ryan-summers
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Apr 5, 2023
@bors
Copy link
Contributor

bors bot commented Apr 5, 2023

try

Build failed:

@ryan-summers
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Apr 5, 2023
@bors
Copy link
Contributor

bors bot commented Apr 5, 2023

try

Build failed:

@ryan-summers
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Apr 5, 2023
@ryan-summers ryan-summers requested a review from jordens April 5, 2023 17:31
@bors
Copy link
Contributor

bors bot commented Apr 5, 2023

try

Build succeeded:

Base automatically changed from feature/bors-support to main April 5, 2023 19:12
@jordens
Copy link
Member

jordens commented Apr 5, 2023

Bors r+

bors bot added a commit that referenced this pull request Apr 5, 2023
237: Adding support for Booster v1.6 channels r=jordens a=ryan-summers

This PR fixes #233 by adding an additional ON/OFF toggle during the channel initial power-up.

~~It's not currently known if this is sufficient to clear the interlocks in all cases because of the unknown states of the power detectors during the power-up process. If the power detectors create transient voltage outputs that exceed the interlock thresholds, the channels will power up in a tripped state.~~

~~However, the most likely case is that the power detectors will remain low during the power-on process and the interlock will not trip, so there's relatively high confidence that this should address v1.6 concerns.~~

It was discovered that the power detectors did not stay low during initialization, but this was remedied by resetting the interlocks immediately after the channel powered up.

Co-authored-by: Ryan Summers <[email protected]>
Co-authored-by: Robert Jördens <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 5, 2023

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

Response status code: 422
{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@ryan-summers
Copy link
Member Author

Bors merge

@bors
Copy link
Contributor

bors bot commented Apr 5, 2023

Build succeeded:

@bors bors bot merged commit cd9b842 into main Apr 5, 2023
@bors bors bot deleted the rs/issue-233/booster-v1.6-support branch April 5, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate additional interlock control for v1.6 channels
3 participants