Initial interlock configuration and RF channel management structure #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
commented
Jul 8, 2020
ryan-summers
commented
Jul 8, 2020
ryan-summers
commented
Jul 9, 2020
ryan-summers
commented
Jul 9, 2020
jordens
requested changes
Jul 9, 2020
|
Note that I realized there's an issue with how the analog pins are implemented (since they are downgraded, we can't pass them to the ADC). I'll implement a refactor for this in a follow-on PR. |
jordens
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
BoosterChannelsmanagement object that is responsible for detecting, instantiating, and interfacing to all Booster RF channels.Instantiating a channel currently implements an algorithm to query for devices on the I2C bus after properly powering up the channel.
The only currently-implemented functionality is the ability to configure interlock thresholds. All thresholds are defaulted to -30dBm.
This structure should allow for extensible control of the channel as the underlying object has all of the available I2C devices instantiated.
The only resource not yet present in RF channels are their reflected and output power ADC inputs. I'll add these in the future when I add support for measuring these signals.