Handling partial MQTT packet writes #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordens
requested changes
Dec 10, 2021
jordens
approved these changes
Dec 10, 2021
|
Thank you for finishing it, sorry for dropping it on you and then disappearing. All the points you brought up certainly seem valid. The only thing that comes to mind now is that publishing can return WriteFail in case the write would block. I wonder if we want to handle it the same way as the partial write. Now the user has to check for this error and retry the same message later, if we reuse this solution they just need to check |
|
@mladedav Thanks for pointing out the other issue. I've added it to the issue tracker and submitted a PR. In the future, I'd recommend posting things like this as an issue - I nearly missed this comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #74 by incorporating changes from #68 with additional safeguards.
Specifically, any attempt to write a packet is now safe guarded by checking that packet writes are acceptable. It's invalid to attempt to send a packet while a partial packet is still being transmitted, as this would corrupt the MQTT connection.
CC @mladedav