Allow configuration of non default port #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brummer-simon
force-pushed
the
make_broker_port_configurable
branch
from
a89fa5e to
237c09c
Compare
ryan-summers
requested changes
Apr 28, 2022
There was a problem hiding this comment.
Hey, thanks for the PR! This looks wonderful - I hadn't considered using TLS with minimq since none of our network stacks support it, but indeed this library is agnostic to the underlying network stack and could well be used on networks that support TLS.
Can you please add an entry for this in the CHANGELOG.md file?
Other than that, I'd like to add one run-time check when trying to modify the broker port to prevent user foot-guns :)
|
@ryan-summers: I'll add the changes. I don't have a proven Network stack with TLS either, I try to piggy-back TLS ontop of a embedded_hal::TcpClientStack implementation. I am curious if this works. |
brummer-simon
force-pushed
the
make_broker_port_configurable
branch
from
237c09c to
63921e4
Compare
|
@ryan-summers: All requested changes were added. |
ryan-summers
approved these changes
Apr 28, 2022
brummer-simon
force-pushed
the
make_broker_port_configurable
branch
from
63921e4 to
99a886e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to set custom target port numbers deviating from 1883.