Refactoring MQTT state management #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordens
requested changes
Aug 17, 2022
There was a problem hiding this comment.
I'd move a bunch of code down into ClientContext, basically everything that doesn't need state() or process_event(). That frees you from having to unpack ClientContext all the time and having to reaching down into it with context_mut() so often. Instead in MqttClient there'll be almost exclusively process_event() and state() and then a call
like context_mut().handle_something().
But otherwise good.
ryan-summers
force-pushed
the
feature/state-refactor
branch
from
bc84e46 to
3c029d0
Compare
|
@jordens I elected to restructure it so that we only keep the |
jordens
requested changes
Aug 22, 2022
jordens
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the state management of the client to be entirely wrapped up in an
smlang::StateMachine.This change is intended to support more complex state management that will be required to support all QoS levels.
This PR also removes public access to the
Minimq.clientobject. It is now exposed viaMinimq::client()to support compatibility going forward.