Updating parsing to avoid copying #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
commented
Aug 23, 2022
| 0x30, // Publish, no QoS | ||
| 0x04, // Remaining length |
There was a problem hiding this comment.
I'm somewhat unsure why this was passing in the past. It looks completely wrong to me - there's obviously 5 bytes following the packet.
jordens
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the packet reception mechanism in Minimq to receive directly from the network stack into the
PacketReader. ThePacketParserhas been broken off thePacketReaderin anticipation of deserialization refactoring in the future.This avoids one copy of the MQTT packet from the receive buffer into the packet reader.
Additionally, this PR updates it so that only a single MQTT packet is read from the network per
poll()execution at most, which paves the way for fixing #80.