Skip to content

Commit

Permalink
refactor: remove quasar typing import from tsconfig preset
Browse files Browse the repository at this point in the history
  • Loading branch information
IlCallo committed Oct 4, 2021
1 parent 0559b35 commit 8076d91
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
5 changes: 0 additions & 5 deletions app/tsconfig-preset.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@
"assets/*": ["src/assets/*"],
"boot/*": ["src/boot/*"]
},
// Forces quasar typings to be included, even if they aren't referenced directly
// Removing this would break `quasar/wrappers` imports if `quasar`
// isn't referenced anywhere, because those typings are declared
// into `@quasar/app` which is imported by `quasar` typings
"types": ["quasar"]
},
// Needed to avoid files copied into 'dist' folder (eg. a `.d.ts` file inside `src-ssr` folder)
// to be evaluated by TS when their original files has been updated
Expand Down
7 changes: 0 additions & 7 deletions ui/build/build.types.js
Original file line number Diff line number Diff line change
Expand Up @@ -270,13 +270,6 @@ function writeIndexDTS (apis) {

addQuasarLangCodes(quasarTypeContents)

// This line must be BEFORE ANY TS INSTRUCTION,
// or it won't be interpreted as a TS compiler directive
// but as a normal comment
// On Vue CLI projects `@quasar/app` isn't available,
// we ignore the "missing package" error because it's the intended behaviour
writeLine(contents, '// @ts-ignore')
writeLine(contents, '/// <reference types="@quasar/app" />')
writeLine(contents, 'import { App, Component, ComponentPublicInstance } from \'vue\'')
writeLine(contents, 'import { LooseDictionary, ComponentConstructor, GlobalComponentConstructor } from \'./ts-helpers\'')
writeLine(contents)
Expand Down

0 comments on commit 8076d91

Please sign in to comment.