Skip to content

Commit

Permalink
fix(docs): improve a11y of footer with role="list"
Browse files Browse the repository at this point in the history
QList used to have role="list" by default, added with #14609. 
But, it was later removed with #14784 since it's also used with the menu role commonly.
So, now QItems have role="listitem" but their parent(QList) doesn't have the list role, which is invalid.
  • Loading branch information
yusufkandemir authored Nov 17, 2023
1 parent 2a399c5 commit ae076cc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/src/layouts/doc-layout/DocPageFooter.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="doc-page-footer doc-brand">
<template v-if="fullscreen">
<nav class="doc-page-footer__nav" v-once>
<q-list v-for="entry in links" :key="entry.name">
<q-list v-for="entry in links" :key="entry.name" role="list">
<q-item-label
class="doc-page-footer__title doc-page-footer__margin row items-end text-weight-bold letter-spacing-225 q-mb-md"
>{{ entry.name }}</q-item-label>
Expand Down

0 comments on commit ae076cc

Please sign in to comment.