feat(docs): be more specific on minimum vue-tsc version in the upgrad…

…e guide #17089
quasarframework · Apr 27, 2024 · fa4c19e · fa4c19e
1 parent 69a3427
commit fa4c19e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/app-vite/lib/modes/electron/electron-builder.js b/app-vite/lib/modes/electron/electron-builder.js
@@ -89,12 +89,12 @@ export class QuasarModeBuilder extends AppBuilder {
       let content = this.readFile(npmrc)
 
       if (content.indexOf('shamefully-hoist') === -1) {
-        content += '\nshamefully-hoist=true'
+        content += '\n# needed by pnpm\nshamefully-hoist=true'
       }
       // very important, otherwise PNPM creates symlinks which is NOT
       // what we want for an Electron app that should run cross-platform
       if (content.indexOf('node-linker') === -1) {
-        content += '\nnode-linker=hoisted'
+        content += '\n# pnpm needs this otherwise it creates symlinks\nnode-linker=hoisted'
       }
 
       this.writeFile(

diff --git a/app-webpack/lib/modes/electron/electron-builder.js b/app-webpack/lib/modes/electron/electron-builder.js
@@ -90,12 +90,12 @@ module.exports.QuasarModeBuilder = class QuasarModeBuilder extends AppBuilder {
       let content = this.readFile(npmrc)
 
       if (content.indexOf('shamefully-hoist') === -1) {
-        content += '\nshamefully-hoist=true'
+        content += '\n# needed by pnpm\nshamefully-hoist=true'
       }
       // very important, otherwise PNPM creates symlinks which is NOT
       // what we want for an Electron app that should run cross-platform
       if (content.indexOf('node-linker') === -1) {
-        content += '\nnode-linker=hoisted'
+        content += '\n# pnpm needs this otherwise it creates symlinks\nnode-linker=hoisted'
       }
 
       this.writeFile(

diff --git a/docs/src/pages/quasar-cli-vite/linter.md b/docs/src/pages/quasar-cli-vite/linter.md
@@ -83,13 +83,13 @@ The linting for a TS project is based on vite-plugin-checker + ESLint + vue-tsc:
 
 ```tabs
 <<| bash Yarn |>>
-$ yarn add --dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0
+$ yarn add --dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0
 <<| bash NPM |>>
-$ npm install --save-dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0
+$ npm install --save-dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0
 <<| bash PNPM |>>
-$ pnpm add -D vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0
+$ pnpm add -D vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0
 <<| bash Bun |>>
-$ bun add --dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0
+$ bun add --dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0
 ```
 
 ::: warning

diff --git a/docs/src/pages/quasar-cli-vite/upgrade-guide.md b/docs/src/pages/quasar-cli-vite/upgrade-guide.md
@@ -209,13 +209,13 @@ We dropped support for our internal linting (quasar.config file > eslint) in fav
 
 ```tabs
 <<| bash Yarn |>>
-$ yarn add --dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0
+$ yarn add --dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0
 <<| bash NPM |>>
-$ npm install --save-dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0
+$ npm install --save-dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0
 <<| bash PNPM |>>
-$ pnpm add -D vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0
+$ pnpm add -D vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0
 <<| bash Bun |>>
-$ bun add --dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0
+$ bun add --dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0
 ```
 
 ::: warning