Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoped slot prarams types for QUploader #11090

Closed
soulsam480 opened this issue Oct 25, 2021 · 4 comments · Fixed by #11591
Closed

Scoped slot prarams types for QUploader #11090

soulsam480 opened this issue Oct 25, 2021 · 4 comments · Fixed by #11591
Assignees
@yusufkandemir
Labels
area/typescript kind/feature 💡

Comments

@soulsam480
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
As quasar is moving towards a fully types component lib, I think it'll be great to have types for QUploader scoped slots too.
image

Describe the solution you'd like
A clear and concise description of what you want to happen.

  • types scoped slot params for QUploader like other components

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@IlCallo @yusufkandemir
@rstoenescu
Copy link
Member

@IlCallo @yusufkandemir Would you be so kind to take care of this, please? It only needs the definition for the slots in the API file instead of the current exemption.

yusufkandemir added a commit to yusufkandemir/quasar that referenced this issue Dec 8, 2021
@yusufkandemir
feat(api/QUploader): Add slot scope types (quasarframework#11090)
641f10d
@yusufkandemir yusufkandemir mentioned this issue Dec 8, 2021
Merged
rstoenescu added a commit that referenced this issue Dec 8, 2021
@yusufkandemir @rstoenescu
feat/fix(ts/api): Allow top-level type definition for slot scopes (fix:
97f2a09 
#11090, #11500) (#11591)

* feat(ts): Allow top-level type definition for slot scopes

* feat(api/QUploader): Add slot scope types (#11090)

* fix(api/QOptionGroup): Correct the slot scope definitions (#11500)

* feat(api/QOptionGroup): Improve slot scope definitions

* refactor(ui/QOptionGroup): Add a note for updating the structure of scopes on Qv3

* Update QOptionGroup.js

* Update uploader-core.js

Co-authored-by: Razvan Stoenescu <[email protected]>
@rstoenescu
Copy link
Member

Changes will be available in Quasar v2.3.5

@paya-cz
Copy link

paya-cz commented Apr 4, 2022

If I try this with the example from documentation, I am still seeing typescript errors for other scope properties such as:

  • queuedFiles
  • uploadedFiles
  • isUploading
  • canAddFiles
  • canUpload

The error I am seeing reads:
Property 'canUpload' does not exist on type 'QUploader'.

quasar - 2.6.5

@paya-cz paya-cz mentioned this issue Apr 20, 2022
Closed
@rafaeldellaquila
Copy link

Still missing this types on v2.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yusufkandemir yusufkandemir

Labels
area/typescript kind/feature 💡
Projects
None yet
Milestone
No milestone
6 participants
@rstoenescu @yusufkandemir @IlCallo @paya-cz @soulsam480 @rafaeldellaquila