Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-vite): preserve JSON config file formatting when updating (fix: #16808) #17754

Conversation

yusufkandemir
Copy link
Member

@yusufkandemir yusufkandemir commented Jan 14, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

Other information:
Resolves #16808, but contains other changes as well.

Affecting package.json, quasar.extensions.json, src-capacitor/package.json, src-capacitor/capacitor.config.json, and api.extendJsonFile

Using confbox package to manage this.

Will be ported to app-webpack if everything is fine.

Affecting `package.json`, `quasar.extensions.json`, `src-capacitor/package.json`, `src-capacitor/capacitor.config.json`, and `api.extendJsonFile`

Using `confbox` package to manage this
@rstoenescu rstoenescu merged commit 011146c into quasarframework:dev Jan 15, 2025
@yusufkandemir yusufkandemir deleted the feat-preserve-formatting-when-updating-json-config-files branch January 15, 2025 12:31
yusufkandemir added a commit to yusufkandemir/quasar that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building capacitor modifies package.json
2 participants