-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add pure CSS icons support #17762
Open
stefanvanherwijnen
wants to merge
1
commit into
quasarframework:dev
Choose a base branch
from
stefanvanherwijnen:purecssicons
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(ui): add pure CSS icons support #17762
stefanvanherwijnen
wants to merge
1
commit into
quasarframework:dev
from
stefanvanherwijnen:purecssicons
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Tests Results 1 files 98 suites 39s ⏱️ Results for commit 1a0697d. |
Actually, for now the better solution is probably to use const iconSet = {
name: 'iconify-json-mdi',
type: {
positive: 'i-mdi-check-circle',
negative: 'i-mdi-alert',
info: 'i-mdi-information',
warning: 'i-mdi-exclamation'
},
arrow: {
up: 'i-mdi-arrow-up',
right: 'i-mdi-arrow-right',
down: 'i-mdi-arrow-down',
left: 'i-mdi-arrow-left',
dropdown: 'i-mdi-menu-down'
},
chevron: {
left: 'i-mdi-chevron-left',
right: 'i-mdi-chevron-right'
},
colorPicker: {
spectrum: 'i-mdi-gradient-vertical',
tune: 'i-mdi-tune',
palette: 'i-mdi-palette-swatch'
},
pullToRefresh: {
icon: 'i-mdi-refresh'
},
carousel: {
left: 'i-mdi-chevron-left',
right: 'i-mdi-chevron-right',
up: 'i-mdi-chevron-up',
down: 'i-mdi-chevron-down',
navigationIcon: 'i-mdi-circle'
},
chip: {
remove: 'i-mdi-close-circle',
selected: 'i-mdi-check'
},
datetime: {
arrowLeft: 'i-mdi-chevron-left',
arrowRight: 'i-mdi-chevron-right',
now: 'i-mdi-clock-outline',
today: 'i-mdi-calendar-today'
},
editor: {
bold: 'i-mdi-format-bold',
italic: 'i-mdi-format-italic',
strikethrough: 'i-mdi-format-strikethrough-variant',
underline: 'i-mdi-format-underline',
unorderedList: 'i-mdi-format-list-bulleted',
orderedList: 'i-mdi-format-list-numbered',
subscript: 'i-mdi-format-subscript',
superscript: 'i-mdi-format-superscript',
hyperlink: 'i-mdi-link',
toggleFullscreen: 'i-mdi-fullscreen',
quote: 'i-mdi-format-quote-close',
left: 'i-mdi-format-align-left',
center: 'i-mdi-format-align-center',
right: 'i-mdi-format-align-right',
justify: 'i-mdi-format-align-justify',
print: 'i-mdi-printer',
outdent: 'i-mdi-format-indent-decrease',
indent: 'i-mdi-format-indent-increase',
removeFormat: 'i-mdi-format-clear',
formatting: 'i-mdi-format-color-text',
fontSize: 'i-mdi-format-size',
align: 'i-mdi-format-align-left',
hr: 'i-mdi-minus',
undo: 'i-mdi-undo',
redo: 'i-mdi-redo',
heading: 'i-mdi-format-size',
heading1: 'i-mdi-format-header-1',
heading2: 'i-mdi-format-header-2',
heading3: 'i-mdi-format-header-3',
heading4: 'i-mdi-format-header-4',
heading5: 'i-mdi-format-header-5',
heading6: 'i-mdi-format-header-6',
code: 'i-mdi-code-tags',
size: 'i-mdi-format-size',
size1: 'i-mdi-numeric-1-box',
size2: 'i-mdi-numeric-2-box',
size3: 'i-mdi-numeric-3-box',
size4: 'i-mdi-numeric-4-box',
size5: 'i-mdi-numeric-5-box',
size6: 'i-mdi-numeric-6-box',
size7: 'i-mdi-numeric-7-box',
font: 'i-mdi-format-font',
viewSource: 'i-mdi-code-tags'
},
expansionItem: {
icon: 'i-mdi-chevron-down',
denseIcon: 'i-mdi-menu-down'
},
fab: {
icon: 'i-mdi-plus',
activeIcon: 'i-mdi-close'
},
field: {
clear: 'i-mdi-close-circle',
error: 'i-mdi-alert-circle'
},
pagination: {
first: 'i-mdi-chevron-double-left',
prev: 'i-mdi-chevron-left',
next: 'i-mdi-chevron-right',
last: 'i-mdi-chevron-double-right'
},
rating: {
icon: 'i-mdi-star'
},
stepper: {
done: 'i-mdi-check',
active: 'i-mdi-pencil',
error: 'i-mdi-alert'
},
tabs: {
left: 'i-mdi-chevron-left',
right: 'i-mdi-chevron-right',
up: 'i-mdi-chevron-up',
down: 'i-mdi-chevron-down'
},
table: {
arrowUp: 'i-mdi-arrow-up',
warning: 'i-mdi-alert',
firstPage: 'i-mdi-chevron-double-left',
prevPage: 'i-mdi-chevron-left',
nextPage: 'i-mdi-chevron-right',
lastPage: 'i-mdi-chevron-double-right'
},
tree: {
icon: 'i-mdi-play'
},
uploader: {
done: 'i-mdi-check',
clear: 'i-mdi-close',
add: 'i-mdi-plus-box',
upload: 'i-mdi-cloud-upload',
removeQueue: 'i-mdi-notification-clear-all',
removeUploaded: 'i-mdi-check-all'
}
}
const iconMapFn = (iconName) => ({
cls: iconName
})
app.use(Quasar, {
// ...,
iconSet: iconSet,
config: {
iconMapFn
}
}) However, the icons in the iconSet will have to be added to the UnoCSS safelist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
This PR adds support for using pure CSS icons in QIcon with help of UnoCSS Icons preset.
With icons preset installed you can now do this:
A prefix different than
i-
can be used but it will also have to be changed in the icons preset settings. You can't use a map similar to other icon sets in this case as UnoCSS tries to match<prefix><collection>-<icon>
or<prefix><collection>:<icon>
.