Fix(QDialog): maximized dialog position if draggable #8908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, This will go into Quasar v1.15.11 and Quasar v2.0.0-beta.13. |
rstoenescu
pushed a commit
that referenced
this pull request
Apr 21, 2021
|
@snakems hello, can you please explain why you need this change? We would need a reproduction case of your problem (in a codepen) because at a first view i cannot understand what it would fix. |
|
@pdanpdan Example bug Drag dialog, then maximize it. Patch reset dialog position in maximized state. |
|
I'm pretty sure it can be solved more simple: https://codepen.io/pdanpdan/pen/PoWxzLm?editors=1010 |
rstoenescu
added a commit
that referenced
this pull request
Apr 21, 2021
This reverts commit e33b440.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.