Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-354 Default to S3 Signature Version V4 #273

Merged
merged 2 commits into from
May 21, 2019
Merged

SDK-354 Default to S3 Signature Version V4 #273

merged 2 commits into from
May 21, 2019

Conversation

chattarajoy
Copy link
Member

@chattarajoy chattarajoy commented May 20, 2019 •
edited
Loading

This includes 2 changes:

  1. Set boto config to use sigv4 when connecting to s3
  2. Set default endpoint for boto connection when endpoint returned is None from Qubole

@chattarajoy chattarajoy requested a review from msumit May 20, 2019 09:00
@chattarajoy chattarajoy changed the base branch from master to unreleased May 20, 2019 11:58
@chattarajoy chattarajoy merged commit aad3a49 into qubole:unreleased May 21, 2019
chattarajoy added a commit that referenced this pull request May 21, 2019
@chattarajoy
SDK-354 Default to S3 Signature Version V4 (#273)
f8e3548 
Signature Version V2 will be deprecated by AWS which was the default for boto, configured it to use v4 signature for s3 authentication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msumit msumit Awaiting requested review from msumit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chattarajoy