-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new:dev:SDK-387:Add hive version support #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write test case for it
self.set_hadoop_settings(custom_hadoop_config, use_qubole_placement_policy, | ||
is_ha, fairscheduler_config_xml, | ||
default_pool, enable_rubix) | ||
self.set_hive_settings(hive_version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify the value of hive_version column in hive_cluster_configs with and without this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarrygo verified from DB with the updated sdk changes and hive version being updated with 3.1
8a95947
to
caec9b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
No description provided.