Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Screen to Manage Rules Collections #64

Closed
epugh opened this issue Mar 6, 2021 · 5 comments · Fixed by #80
Closed

Admin Screen to Manage Rules Collections #64

epugh opened this issue Mar 6, 2021 · 5 comments · Fixed by #80

Comments

@epugh
Copy link
Contributor

epugh commented Mar 6, 2021

Today, we have to use a API call to create a Solr Index in SMUI:

SOLR_INDEX_ID=`curl -S -X PUT -H "Content-Type: application/json" -d '{"name":"ecommerce", "description":"Ecommerce Demo"}' http://localhost:9000/api/v1/solr-index | jq -r .returnId`

I am working with a client that, if we are successful, will have many collections. They could use this API call, however it would be nice if SMUI had an admin interface that let you via clicking create and update new "Solr Index". Bonus points on if you could edit the deployment scripts via the web interface ;-)

@renekrie
Copy link
Collaborator

renekrie commented Mar 6, 2021

It sounds great, but let's keep in mind that it should also work for ES some day, and Solr access is not always as simple as an HTTP call --> we'll need good abstractions

@pbartusch
Copy link
Collaborator

The internal concept SolrIndex is deprecated. We already started to refactor it to the concept of a Deployment Channel in the documentation. The corresponding code refactoring should be part of that issue, when establishing an admin interface for the channels. The concept is decoupled from a specific search engine as it will only be used to organise rules.

Note: when refactoring the SolrIndex also the database structure needs to be touched.

@pbartusch
Copy link
Collaborator

Reminder: When establishing an admin interface to manage the Deployment Channels, it should also be considered to establish an admin interface for managing the Rule Tags (currently configured via an explicit file referred by the application.conf).

@pbartusch
Copy link
Collaborator

linked also to #65

@epugh
Copy link
Contributor Author

epugh commented Oct 28, 2021

I have finished PR #80 and I believe that it goes a long way to solving this. In conversation with @renekrie he suggested that the term "Rules Collection" be used, since it's a grouping of Rules. I'd love some review of the PR.

@epugh epugh changed the title Admin Screen to Manage Deployment Channels Admin Screen to Manage Rules Collections Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants