-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce basic admin screen for managing "Rules Collection" and "Suggested Fields" #80
Conversation
Much as I like an admin API, I can see a danger that we create even more Solr-specfic code which will impede opening up SMUI to Elasticsearch even further. I think we should abstract the search engine in SMUI first, before building this type of Admin features |
@epugh Just to share in public the idea that we discussed separately: This features need not depend on Solr. What we manage is a In Solr they happen to end up under a collection, like for In Elasticsearch, the rewriters exist independent of indexes (under A |
…Index. This lets you list and delete a record out of the SolrIndex table. Eventually this should all be renamed to "RulesCollection" ;-)
…lection creation and rules collection listing component to the Header Nav component.
I wanted to share my progress... I've now got the "Rules Collection" screen working, it even manages to update the HeaderNav drop down as you add/remove collections ;-). I'd love to find out what the path is to getting this merged in is... I'm going to be tackling user/rules collections permissions next to support my customer. |
Okay, I think I'm now done ;-) @pbartusch I'd love your review on this. Maybe we need to set up a time and chat? |
This looks really useful for customers like us who are starting to use SMUI and need to open the role of searchandizer. Anything that helps managing the collections from the Admin is a huge plus! |
Hi @xaviersanchez , I agree , the feature is helpful in general. @epugh : Thanks for sharing the effort with this PR. Just as a note: other clients use the API and ensure in the deployment routine , that the expected deployment channels are present - that might be an attractive alternative , as it works automatically (deployment channels are usually tight to the index structure, and therefore a likely concern to the Search Dev team). @epugh : The PR is extensive , just as a quick feedback: Critical: Deleting a deployment channel (a.k.a
It should at least be checked, that a deleted deployment channel is empty. Other:
|
Just a side note (hint , @epugh ) : when I build SMUI today (sbt docker) it seemed, that the repo location for sbt from debian is not available any more :-( I updated the dependency with branch Hope , that'll save you some time. |
I wonder if we need a confirmation button on the delete of a Rules Collection, that mentions that it is in use...? Maybe a more custom warning like "Are you sure you want to delete Spanish webshop, it has X rules" |
…ggested field names for same solr index
…are met for deleting one at the SearchManagementRepository level. I decided NOT to try and introduce foreign keys, and instead programmatically check the existence of related objects before allowing a delete.
This is now Done! I added checks at the
Done! |
Check out |
I've retested, and now the drop down does populate when you create new rows. |
I am looking at how we can make it easier to add new Solr Collections to SMUI for organizations that have lots of webshops. This is a very much draft WIP just to help me learn how to write code!