Use subject claim from jwt #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mkr Would you have time to have a quick look at this? Thanks very much in advance |
mkr
reviewed
May 22, 2023
mkr
reviewed
May 22, 2023
mkr
reviewed
May 22, 2023
mkr
reviewed
May 22, 2023
|
Apart from style issues this looks ok to me. |
|
Thanks @mkr , it's fixed 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the JWTJsonAuthenticatedAction class to use the subject claim (if present), to enhance the request with the user name, similar to what is done in the BasicAuthAuthenticatedAction class.
I added a couple tests to check that this functionality works even if there is no "sub" claim. Disclaimer: Is the first scala test I write, so maybe the idea is right but the implementation sucks.