-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slug to the Metadata & QuestChainInfo #2
Conversation
bump package json version
Hey lint is failing here. Can you run Also we should update ALL subgraphs before creating a new release |
@@ -44,13 +39,8 @@ query QuestChainSearch($search: String, $limit: Int) { | |||
} | |||
} | |||
|
|||
query QuestChainSearch($search: String, $limit: Int) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this might be a mistake?
We need this for the "search" functionality to work.
We should rather create a new query instead of replacing this.
I'm also thinking we need a query for fetching ALL slugs so that when a user is creating a new slug we can check and make sure there are no conflicts.
But I'm still worried there might be a race condition here where two people set the slug at the same time, and there is no way for us to stop that from happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this might be a mistake?
there were 2 exactly queries, which were exactly the same, so i replaced one of them.
I'm also thinking we need a query for fetching ALL slugs so that when a user is creating a new slug we can check and make sure there are no conflicts.
we'd need to fetch all quest chains and return only their slugs for this to work, right?
race condition
let's not think about this edge case 😅
update package.json
No description provided.