Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slug to the Metadata & QuestChainInfo #2

Merged
merged 6 commits into from
Jan 9, 2023
Merged

Add slug to the Metadata & QuestChainInfo #2

merged 6 commits into from
Jan 9, 2023

Conversation

vidvidvid
Copy link
Member

No description provided.

@vidvidvid vidvidvid requested a review from dan13ram December 13, 2022 19:08
@dan13ram
Copy link
Member

Hey lint is failing here. Can you run yarn lint and push once ?

Also we should update ALL subgraphs before creating a new release

@@ -44,13 +39,8 @@ query QuestChainSearch($search: String, $limit: Int) {
}
}

query QuestChainSearch($search: String, $limit: Int) {
Copy link
Member

@dan13ram dan13ram Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this might be a mistake?
We need this for the "search" functionality to work.
We should rather create a new query instead of replacing this.

I'm also thinking we need a query for fetching ALL slugs so that when a user is creating a new slug we can check and make sure there are no conflicts.

But I'm still worried there might be a race condition here where two people set the slug at the same time, and there is no way for us to stop that from happening.

Copy link
Member Author

@vidvidvid vidvidvid Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this might be a mistake?

there were 2 exactly queries, which were exactly the same, so i replaced one of them.

I'm also thinking we need a query for fetching ALL slugs so that when a user is creating a new slug we can check and make sure there are no conflicts.

we'd need to fetch all quest chains and return only their slugs for this to work, right?

race condition

let's not think about this edge case 😅

@dan13ram dan13ram merged commit eab2895 into dev Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants