fix incorrect documentation of sentPacketHistory.Iterate #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2749 +/- ##
=======================================
Coverage 86.52% 86.52%
=======================================
Files 128 128
Lines 9960 9960
=======================================
Hits 8617 8617
Misses 1010 1010
Partials 333 333
Continue to review full report at Codecov.
|
|
Turns out the documentation was right, and the test case I added is wrong. We need to test that we actually iterate over all packets instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using this in https://github.com/lucas-clemente/quic-go/blob/bed802aee5732c8fe373bf4f71e789bea2f7f11f/internal/ackhandler/sent_packet_handler.go#L158-L166
I thought this was not a safe thing to do, but it turns out to be. Therefore, we can revise the documentation, and add a test case to make sure we don't introduce a regression at some point.