Embed sslkeylog files into pcaps #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sedrubal
force-pushed
the
embed-sslkeylog-into-pcap
branch
from
c5b8fd8 to
d3978ad
Compare
marten-seemann
force-pushed
the
master
branch
2 times, most recently
from
365141c to
e73ec56
Compare
|
@marten-seemann This looks like a really cool addition, is there anything I can do to help land this PR? |
|
@jlaine Sure, let's get it in! First of all, this PR would need to be rebased. If you could test that this actually works, we should be good to go. |
Comment on lines
+164
to
+169
| if ( | ||
| os.path.isfile(trace_with_secrets) | ||
| and os.path.getsize(trace_with_secrets) > 0 | ||
| ): | ||
| # already injected | ||
|
|
There was a problem hiding this comment.
Why would this happen?
There was a problem hiding this comment.
It's a long time since I wrote this. I think it was an edge case in my specific setup where I experimented with trace files. I guess you can remove it.
Feel free to take over the work on this PR. I work on different topics and can't spend time on it anymore, sorry.
larseggert
added a commit
to larseggert/quic-interop-runner
that referenced
this pull request
Sep 11, 2024
Alternative to quic-interop#269 Thanks to @sedrubal for the groundwork
marten-seemann
pushed a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With pcapng it is possible to embed the secrets from sslkeylog directly into the trace using
editcap. This makes it easier when you want to analyze the pcap files (e.g. using Wireshark).