-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This commit includes a patch to the QEMU test suite. The tcg/multiarch/linux/linux-test.c file fails to compile under -Wall with LLVM 15.0.3 This is likely due to [recent improvements][1] to the -Wno-unused-but-set-variable diagnostic to fix false negatives when post/pre increment/decrement operator are involved. The patch simply deletes the unused variable since the semantics of the test will remain the same. [1]: llvm/llvm-project#54595 (comment) Signed-off-by: Mukilan Thiyagarajan <[email protected]>
- Loading branch information
1 parent
a544985
commit db6d5cc
Showing
3 changed files
with
28 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
--- qemu/tests/tcg/multiarch/linux/linux-test.c.old 2022-11-07 15:33:05.862410841 +0530 | ||
+++ qemu/tests/tcg/multiarch/linux/linux-test.c 2022-11-07 15:33:38.982404440 +0530 | ||
@@ -332,12 +332,11 @@ | ||
fd_set rfds, wfds; | ||
int fds[2], fd_max, ret; | ||
uint8_t ch; | ||
- int wcount, rcount; | ||
+ int rcount; | ||
|
||
chk_error(pipe(fds)); | ||
chk_error(fcntl(fds[0], F_SETFL, O_NONBLOCK)); | ||
chk_error(fcntl(fds[1], F_SETFL, O_NONBLOCK)); | ||
- wcount = 0; | ||
rcount = 0; | ||
for(;;) { | ||
FD_ZERO(&rfds); | ||
@@ -360,7 +359,6 @@ | ||
if (FD_ISSET(fds[1], &wfds)) { | ||
ch = 'a'; | ||
chk_error(write(fds[1], &ch, 1)); | ||
- wcount++; | ||
} | ||
} | ||
} |