refactor(reflection): avoid String8

Reduce our use of std::string/String8 to reduce binary bloat: #689
quick-lint · Oct 27, 2023 · 50abdd2 · 50abdd2
1 parent da23750
commit 50abdd2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/quick-lint-js/reflection/cxx-parser.cpp b/src/quick-lint-js/reflection/cxx-parser.cpp
@@ -673,11 +673,12 @@ bool CXX_Diagnostic_Types_Parser::is_valid_code_string(
          this->lexer_.is_digit(code_string[4]);
 }
 
-String8 CXX_Diagnostic_Types_Parser::next_unused_diag_code_string() {
+String8_View CXX_Diagnostic_Types_Parser::next_unused_diag_code_string() {
+  Span<char> code_string_raw =
+      this->allocator_.allocate_uninitialized_span<char>(8);
   for (int i = 1; i <= 9999; ++i) {
-    char code_string_raw[8];
-    std::snprintf(code_string_raw, sizeof(code_string_raw), "E%04d", i);
-    String8_View code_string = to_string8_view(code_string_raw);
+    std::snprintf(code_string_raw.data(), code_string_raw.size(), "E%04d", i);
+    String8_View code_string = to_string8_view(code_string_raw.data());
     bool in_use = any_of(this->parsed_types,
                          [&](const CXX_Diagnostic_Type& type) {
                            return code_string == type.code_string;
@@ -687,7 +688,7 @@ String8 CXX_Diagnostic_Types_Parser::next_unused_diag_code_string() {
                            return code_string == reserved_code.code;
                          });
     if (!in_use) {
-      return String8(code_string);
+      return code_string;
     }
   }
   QLJS_UNIMPLEMENTED();

diff --git a/src/quick-lint-js/reflection/cxx-parser.h b/src/quick-lint-js/reflection/cxx-parser.h
@@ -193,7 +193,7 @@ class CXX_Diagnostic_Types_Parser : private CXX_Parser_Base {
 
   bool is_valid_code_string(String8_View code_string);
 
-  String8 next_unused_diag_code_string();
+  String8_View next_unused_diag_code_string();
 
   using Base::fatal_at;