Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test (cygwin) #184

Closed
bnoordhuis opened this issue Dec 7, 2023 · 0 comments · Fixed by #202
Closed

Flaky test (cygwin) #184

bnoordhuis opened this issue Dec 7, 2023 · 0 comments · Fixed by #202
Labels
bug Something isn't working

Comments

@bnoordhuis
Copy link
Contributor 

build/qjs tests/test_std.js
Error: assertion failed: got |0|, expected |3|
    at assert (tests/test_std.js:20)
    at test_os_exec (tests/test_std.js:249)
    at <anonymous> (tests/test_std.js:270)

Which is this line:

assert(status & 0x7f, os.SIGQUIT);
@bnoordhuis bnoordhuis added the bug Something isn't working label Dec 7, 2023
bnoordhuis added a commit to bnoordhuis/quickjs that referenced this issue Dec 10, 2023
@bnoordhuis
Disable flaky test on Cygwin
ab89cb0 
Unclear why sending a SIGQUIT signal sometimes works and sometimes
doesn't but it's probably some kind of race condition in Cygwin's
emulation layer.

Fixes: quickjs-ng#184
@bnoordhuis bnoordhuis mentioned this issue Dec 10, 2023
Merged
bnoordhuis added a commit to bnoordhuis/quickjs that referenced this issue Dec 10, 2023
@bnoordhuis
Change to SIGTERM in child process test
e10d75a 
The hope is that switching from SIGQUIT to SIGTERM will resolve the
test's flakiness on Cygwin.

Refs: quickjs-ng#184
@bnoordhuis bnoordhuis mentioned this issue Dec 10, 2023
Merged
bnoordhuis added a commit that referenced this issue Dec 11, 2023
@bnoordhuis
Switch to SIGTERM in child process test (#203)
f7f1906 
The hope is that switching from SIGQUIT to SIGTERM will resolve the
test's flakiness on Cygwin.

Refs: #184
bnoordhuis added a commit to bnoordhuis/quickjs that referenced this issue Dec 11, 2023
@bnoordhuis
Disable flaky test on Cygwin
9d708c6 
Unclear why sending a SIGQUIT signal sometimes works and sometimes
doesn't but it's probably some kind of race condition in Cygwin's
emulation layer.

Fixes: quickjs-ng#184
bnoordhuis added a commit that referenced this issue Dec 11, 2023
@bnoordhuis
Disable flaky test on Cygwin (#202)
40771c9 
Unclear why sending a SIGQUIT signal sometimes works and sometimes
doesn't but it's probably some kind of race condition in Cygwin's
emulation layer.

Fixes: #184
@bnoordhuis bnoordhuis mentioned this issue Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable flaky test on Cygwin bnoordhuis/quickjs
1 participant
@bnoordhuis