Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report async failures via exit code #514

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Report async failures via exit code #514

merged 1 commit into from
Sep 10, 2024

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Sep 9, 2024

Fixes: #340

@saghul saghul requested a review from bnoordhuis September 9, 2024 21:16
@saghul
Copy link
Contributor Author

saghul commented Sep 9, 2024

Comes after #513

@saghul
Copy link
Contributor Author

saghul commented Sep 9, 2024 

Error: assertion failed: got |false|, expected |true|
   at assert (tests/test_std.js:21:51)
   at d (tests/test_std.js:289:33)

make: *** [test] Error 1

Ha, looks like the PR works :-P

@saghul
Copy link
Contributor Author

saghul commented Sep 10, 2024

Greeeeen! @bnoordhuis PTAL!

bnoordhuis
bnoordhuis approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion.

quickjs-libc.c Show resolved Hide resolved
@saghul
Copy link
Contributor Author

saghul commented Sep 10, 2024

Done! I also initialized min_delay to INT32_MAX, 10000 looked very arbitrary.

@saghul saghul merged commit 7ad9807 into master Sep 10, 2024
50 checks passed
@saghul saghul deleted the exit-timer-errors branch September 10, 2024 19:42
@saghul saghul mentioned this pull request Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qjs/std should report async failures via exit code
2 participants
@saghul @bnoordhuis