-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JS_SealObject and JS_FreezeObject methods #819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still using JSValueConst
Apparently, calling "git add" prior to committing really helps^^ |
c638925
to
fda984f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. New API so it'd be good to get sign-off from at least one other committer. @saghul?
For optimisation, we share some huge objects in different scripts and make them "const" to prevent user from accidentally changing them.