Expose JS_ToBoolean(), JS_ToNumber(), JS_ToObject(), and JS_SetUncatchableError()
#824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tUncatchableError()`
saghul
reviewed
Jan 14, 2025
saghul
reviewed
Jan 14, 2025
saghul
approved these changes
Jan 14, 2025
|
Thanks @kasperisager ! Feel free to open a PR adding your project here: https://quickjs-ng.github.io/quickjs/projects |
bnoordhuis
reviewed
Jan 14, 2025
| @@ -616,6 +616,7 @@ JS_EXTERN JSValue JS_Throw(JSContext *ctx, JSValue obj); | |||
| JS_EXTERN JSValue JS_GetException(JSContext *ctx); | |||
| JS_EXTERN JS_BOOL JS_HasException(JSContext *ctx); | |||
| JS_EXTERN JS_BOOL JS_IsError(JSContext *ctx, JSValue val); | |||
| JS_EXTERN void JS_SetUncatchableError(JSContext *ctx, JSValue val, JS_BOOL flag); | |||
There was a problem hiding this comment.
I won't PR right away because that conflicts with #821 but IMO flag is too cryptic and should have been called something like is_uncatchable, or have been left out and been replaced with:
JS_EXTERN void JS_SetUncatchableError(JSContext *ctx, JSValue val);
JS_EXTERN void JS_ClearUncatchableError(JSContext *ctx, JSValue val);
There was a problem hiding this comment.
Please do, I'll rebase no problem. Sorry I pulled trigger too quickly 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.