fix typo and remove commented code

quickwit-oss · Feb 8, 2023 · 58a8563 · 58a8563
1 parent a045447
commit 58a8563
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 18 deletions.
diff --git a/quickwit/quickwit-proto/protos/quickwit/search_api.proto b/quickwit/quickwit-proto/protos/quickwit/search_api.proto
@@ -47,7 +47,7 @@ service SearchService {
 
   // Root list terms API.
   // This RPC identifies the set of splits on which the query should run on,
-  // and dispatches the several calls to `LeafListTerm`.
+  // and dispatches the several calls to `LeafListTerms`.
   //
   // It is also in charge of merging back the results.
   rpc RootListTerms(ListTermsRequest) returns (ListTermsResponse);

diff --git a/quickwit/quickwit-proto/src/quickwit.rs b/quickwit/quickwit-proto/src/quickwit.rs
@@ -606,7 +606,7 @@ pub mod search_service_client {
         }
         /// Root list terms API.
         /// This RPC identifies the set of splits on which the query should run on,
-        /// and dispatches the several calls to `LeafListTerm`.
+        /// and dispatches the several calls to `LeafListTerms`.
         ///
         /// It is also in charge of merging back the results.
         pub async fn root_list_terms(
@@ -701,7 +701,7 @@ pub mod search_service_server {
         ) -> Result<tonic::Response<Self::LeafSearchStreamStream>, tonic::Status>;
         /// Root list terms API.
         /// This RPC identifies the set of splits on which the query should run on,
-        /// and dispatches the several calls to `LeafListTerm`.
+        /// and dispatches the several calls to `LeafListTerms`.
         ///
         /// It is also in charge of merging back the results.
         async fn root_list_terms(

diff --git a/quickwit/quickwit-search/src/cluster_client.rs b/quickwit/quickwit-search/src/cluster_client.rs
@@ -153,21 +153,6 @@ impl ClusterClient {
     ) -> crate::Result<LeafListTermsResponse> {
         let response_res = client.leaf_list_terms(request.clone()).await;
         // TODO: implement retry
-        // let retry_policy = LeafSearchRetryPolicy {};
-        // if let Some(retry_request) = retry_policy.retry_request(request, &response_res) {
-        // assert!(!retry_request.split_offsets.is_empty());
-        // client = retry_client(
-        // &self.client_pool,
-        // &client,
-        // &retry_request.split_offsets[0].split_id,
-        // )?;
-        // debug!(
-        // "Leaf search response error: `{:?}`. Retry once to execute {:?} with {:?}",
-        // response_res, retry_request, client
-        // );
-        // let retry_result = client.leaf_search(retry_request).await;
-        // response_res = merge_leaf_search_results(response_res, retry_result);
-        // }
         response_res
     }
 }