Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement phrase prefix query #3329

Merged
merged 9 commits into from
Jun 1, 2023
Merged

Conversation

trinity-1686a
Copy link
Contributor

Description

fix #2266

blocked by quickwit-oss/tantivy#2042 and quickwit-oss/tantivy#2043

How was this PR tested?

manual test against the ES api, with a slightly modified gh-archive (field payload.pull_request.body projected to body to allow testing both json and string fields):

{
  "query": {
    "match_phrase_prefix": {
      "payload.pull_request.body": { // or just body
        "query": "this looks goo" // or just `looks goo` or `goo`
      }
    }
  }
}

@trinity-1686a trinity-1686a marked this pull request as draft May 15, 2023 10:39
@trinity-1686a
Copy link
Contributor Author

there will be some conflicts with #3321. This PR should go after the other, so it can leverage the new infrastructure wrt to tokenization (i.e. FullTextParams)

@trinity-1686a trinity-1686a force-pushed the trinity--phrase-prefix-query branch from 7607cbf to 2032682 Compare May 22, 2023 14:43
@trinity-1686a trinity-1686a marked this pull request as ready for review May 22, 2023 15:03
@trinity-1686a trinity-1686a requested a review from fulmicoton May 22, 2023 15:06
Copy link
Contributor

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test in the es compatibility test in the rest-api-tests thingy?

You can just add a file in
quickwit/rest-api-tests/scenarii/es_compatibility
and mimick what is done in the other files.

Then you can run the test on an empty running elastic or a running quickwit
(default ports) by running

./rest_api_test.py --engine elasticsearch
./rest_api_test.py --engine quickwit

@trinity-1686a trinity-1686a enabled auto-merge (squash) June 1, 2023 08:05
@trinity-1686a trinity-1686a merged commit 0094386 into main Jun 1, 2023
@trinity-1686a trinity-1686a deleted the trinity--phrase-prefix-query branch June 1, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Phrase Prefix
2 participants