-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement phrase prefix query #3329
Conversation
there will be some conflicts with #3321. This PR should go after the other, so it can leverage the new infrastructure wrt to tokenization (i.e. |
warmup and json-fields are still missing
requires updating tantivy
7607cbf
to
2032682
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test in the es compatibility test in the rest-api-tests thingy?
You can just add a file in
quickwit/rest-api-tests/scenarii/es_compatibility
and mimick what is done in the other files.
Then you can run the test on an empty running elastic or a running quickwit
(default ports) by running
./rest_api_test.py --engine elasticsearch
./rest_api_test.py --engine quickwit
Description
fix #2266
blocked by quickwit-oss/tantivy#2042 and quickwit-oss/tantivy#2043
How was this PR tested?
manual test against the ES api, with a slightly modified gh-archive (field
payload.pull_request.body
projected tobody
to allow testing both json and string fields):