-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some documentation issues #225
Comments
The documentation is very rough and we know there is a lot of work to be done. We're all volunteers though so fixes happen as time allows.
Could you specify in what way it's incorrect? This will help anyone else who comes along and has a few minutes to spare to submit a quick fix for a low-hanging-fruit issue.
You should only be calling commit after adding a batch of documents, not after each individual document. |
Thank you for your hard work. I just hope to make a contribution to this great project. My comments are not meant to offend or criticize. class Snippet(object):
"""
Tantivy schema.
The schema is very strict. To build the schema the `SchemaBuilder` class is
provided.
""" It seems to have mistakenly used the documentation for Schema. |
I did call |
…-oss#225) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I've encountered several documentation issues.
In
tantivy.py
, the comment documentation for the Snippet class is incorrect.Additionally, after implementing a piece of code for adding indexes based on the example, I faced a "ValueError: An error occurred in a thread: 'An index writer was killed.. A worker thread encountered an error (io::Error most likely) or panicked.'" after calling
index writer.commit()
tens of thousands of times. However, the issue was resolved after following the example in the tests directory, wherewriter.wait_merging_threads()
is called after multiple commits. I am not sure if this is an issue on my end, but if it's not, then the documentation should be updated to clarify this process. Thank you for your work!The text was updated successfully, but these errors were encountered: