Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deps for unicode regex compiling #1373

Merged
merged 2 commits into from
May 20, 2022
Merged

Conversation

saroh
Copy link
Contributor

@saroh saroh commented May 16, 2022

following #1356

Fixes ./example/json_field.rs (which fails with v0.17)

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Syntax(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
regex parse error:
    \\(\+|\^|`|:|\{|\}|"|\[|\]|\(|\)|\~|!|\\|\*|\s)
                                                ^^
error: Unicode-aware Perl class not found (make sure the unicode-perl feature is enabled)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
)', /home/saroh/.cargo/git/checkouts/tantivy-1e252d10ffb11ab7/3223bdf/query-grammar/src/query_grammar.rs:29:64

+doc lint

maybe we could add the example somewhere in the doc so they're tested/serve as tests ?

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #1373 (d7bfed3) into main (3223bdf) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
- Coverage   94.23%   94.23%   -0.01%     
==========================================
  Files         234      234              
  Lines       42829    42829              
==========================================
- Hits        40362    40361       -1     
- Misses       2467     2468       +1     
Impacted Files Coverage Δ
src/collector/multi_collector.rs 99.30% <ø> (ø)
src/fastfield/serializer/mod.rs 91.30% <0.00%> (-1.45%) ⬇️
src/fastfield/reader.rs 89.91% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3223bdf...d7bfed3. Read the comment docs.

@fulmicoton fulmicoton merged commit 9ee4772 into quickwit-oss:main May 20, 2022
@fulmicoton
Copy link
Collaborator

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants