Extend FAQ #1388
Extend FAQ #1388
Conversation
|
Not sure if this is the best place for this. |
Codecov Report
@@ Coverage Diff @@
## main #1388 +/- ##
=======================================
Coverage 94.29% 94.29%
=======================================
Files 236 236
Lines 43418 43418
=======================================
Hits 40942 40942
Misses 2476 2476 Continue to review full report at Codecov.
|
README.md
Outdated
|
|
||
| ### When will my documents be searchable during indexing? | ||
| - Documents will be searchable after a `commit`. A commit can be executed manually, or when reaching the memory budget during indexing. Comitting means the segment will be flushed to disk. |
There was a problem hiding this comment.
That's incorrect.
A commit can only be done manually.
Segment getting serialized to disk can happen when we reach the memory budget, but the data will not be made searchable until a manual commit is done.
It might be important to also add that existing reader's need to be reload for changes to be visible.
There was a problem hiding this comment.
Documents will be searchable after a commit, which can only be done manually. When reaching the memory budget during indexing, a segment can get serialized to disk, but the data will not be searchable until a commit is done (not necessary to repeat "manual commit" here imo). It is important to reload the existing reader for changes to be visible.
No description provided.