clippy #1452
Merged
clippy #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,5 @@ | |||
| #![allow(clippy::derive_partial_eq_without_eq)] | |||
There was a problem hiding this comment.
Does it really make sense to allow this instead of just adding the derive or is this mainly about the code noise of doing that?
There was a problem hiding this comment.
The lint feels pointless to me.
Codecov Report
@@ Coverage Diff @@
## main #1452 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 237 237
Lines 44405 44406 +1
=======================================
+ Hits 41830 41831 +1
Misses 2575 2575
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.