GCD wrapper uses DividerU64 #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
gcd_is_divide
branch
from
41f3c9d to
c45f98c
Compare
PSeitz
reviewed
Aug 24, 2022
| Box::new( | ||
| self.fastfield_accessor | ||
| .iter() | ||
| .map(|val| (val - self.base_value) / self.gcd), | ||
| .map(|val| self.gcd.divide(val - self.base_value)), |
There was a problem hiding this comment.
if you release a new version of fastdivide with the Div impl, the code could stay the same, which is more readable
PSeitz
approved these changes
Aug 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #1478 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 239 239
Lines 44768 44769 +1
=======================================
+ Hits 42120 42121 +1
Misses 2648 2648
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.