Perf fix on the MonotonicMapping column #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
perf-fix-column
branch
2 times, most recently
from
69ada7f to
14da9c4
Compare
PSeitz
reviewed
Sep 14, 2022
fulmicoton
force-pushed
the
perf-fix-column
branch
5 times, most recently
from
c971bfb to
a1997a3
Compare
The Monotonic mapping was using the default implementation for `get_range` and `.iter`. As a result, some of the column used in merge (e.g. multivalued fast fields) were exhibiting a very strong performance regression.
fulmicoton
force-pushed
the
perf-fix-column
branch
from
a1997a3 to
ac0ddb9
Compare
PSeitz
approved these changes
Sep 15, 2022
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Monotonic mapping was using the default implementation for
get_rangeand.iter.As a result, some of the column used in merge (e.g. multivalued fast fields) were exhibiting a very strong performance regression.