Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmarks for multivalued fastfield merge #1541

Merged
merged 1 commit into from
Sep 22, 2022
Merged

add benchmarks for multivalued fastfield merge #1541

merged 1 commit into from
Sep 22, 2022

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Sep 22, 2022

OLD CODE

test fastfield::bench::bench_multi_value_ff_merge_few_segments                                                           ... bench:  46,103,960 ns/iter (+/- 2,066,083)
test fastfield::bench::bench_multi_value_ff_merge_many_segments                                                          ... bench:  83,073,036 ns/iter (+/- 4,373,615)
test fastfield::bench::bench_multi_value_ff_merge_many_segments_log_merge                                                ... bench:  64,178,576 ns/iter (+/- 1,466,700)

NEW CODE

running 3 tests
test fastfield::multivalued::bench::bench_multi_value_ff_merge_few_segments                                              ... bench:  57,379,523 ns/iter (+/- 3,220,787)
test fastfield::multivalued::bench::bench_multi_value_ff_merge_many_segments                                             ... bench:  90,831,688 ns/iter (+/- 1,445,486)
test fastfield::multivalued::bench::bench_multi_value_ff_merge_many_segments_log_merge                                   ... bench: 158,313,264 ns/iter (+/- 28,823,250)



@PSeitz PSeitz requested a review from fulmicoton September 22, 2022 04:18
Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved...

As far as I can tell the multivalued stuff always only use the
two following adhoc columns

  • MultivalueStartIndex
  • SortedDocIdMultiValueColumn

Do you know which one is the most likely culprit?

@PSeitz PSeitz merged commit 6f066c7 into main Sep 22, 2022
@PSeitz PSeitz deleted the add_bench branch September 22, 2022 07:28
@PSeitz
Copy link
Contributor Author

PSeitz commented Sep 22, 2022

It's SortedDocIdMultiValueColumn::get_val via Line::train

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants