Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse samples, add EstimateColumn #1551

Closed
wants to merge 1 commit into from
Closed

reuse samples, add EstimateColumn #1551

wants to merge 1 commit into from

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Sep 25, 2022

estimations can be expensive since the samples span the whole column
and depending on the implementation get_val can not be easily computed
without an index.
EstimateColumn adds a view over the column which limits num_vals
to 100_000.

estimations can be expensive since the samples span the whole column
and depending on the implementation get_val can not be easily computed
without an index.
EstimateColumn adds a view over the column which limits num_vals
to 100_000.
@PSeitz PSeitz requested a review from fulmicoton September 25, 2022 15:55
@codecov-commenter
Copy link

Codecov Report

Merging #1551 (ba3215b) into main (dac7da7) will decrease coverage by 0.03%.
The diff coverage is 62.82%.

@@            Coverage Diff             @@
##             main    #1551      +/-   ##
==========================================
- Coverage   93.94%   93.91%   -0.04%     
==========================================
  Files         249      249              
  Lines       46066    46101      +35     
==========================================
+ Hits        43277    43296      +19     
- Misses       2789     2805      +16     
Impacted Files Coverage Δ
fastfield_codecs/src/serialize.rs 85.08% <5.88%> (-0.40%) ⬇️
fastfield_codecs/src/column.rs 80.52% <59.37%> (-4.29%) ⬇️
fastfield_codecs/src/bitpacked.rs 98.43% <100.00%> (ø)
fastfield_codecs/src/blockwise_linear.rs 99.21% <100.00%> (ø)
fastfield_codecs/src/lib.rs 99.38% <100.00%> (+0.01%) ⬆️
fastfield_codecs/src/line.rs 99.14% <100.00%> (-0.05%) ⬇️
fastfield_codecs/src/linear.rs 98.70% <100.00%> (ø)
src/fastfield/multivalued/mod.rs 97.23% <0.00%> (-1.19%) ⬇️
.../termdict/sstable_termdict/sstable/block_reader.rs 82.14% <0.00%> (+1.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fulmicoton
Copy link
Collaborator

Closing as it was adressed by #1587

@fulmicoton fulmicoton closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants