Move ArcBytes,WeakArcBytes to mmap_directory. #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building without default features (so without mmap, etc), there are some warnings about unused things. This fixes the ones related to `ArcBytes` and `WeakArcBytes`, which are only used with the `mmap_directory` code.
|
I left these as They aren't used in any public API, so keeping them internal to the mmap code seems like the right option? |
|
Yes that's much better. Thank you @waywardmonkeys |
fulmicoton
approved these changes
Sep 27, 2022
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building without default features (so without mmap, etc), there are some warnings about unused things. This fixes the ones related to
ArcBytesandWeakArcBytes, which are only used with themmap_directorycode.