Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable linear codec for multivalue values #1591

Merged
merged 3 commits into from
Oct 5, 2022
Merged

disable linear codec for multivalue values #1591

merged 3 commits into from
Oct 5, 2022

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Oct 5, 2022

disable linear codec for multivalue values
don't materialize index column on merge
use simpler chain() variant

@PSeitz PSeitz force-pushed the ff_refact branch 2 times, most recently from bc98445 to dd266c7 Compare October 5, 2022 04:15
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #1591 (d742275) into main (7905965) will increase coverage by 0.02%.
The diff coverage is 97.00%.

@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
+ Coverage   93.75%   93.77%   +0.02%     
==========================================
  Files         252      252              
  Lines       46317    46380      +63     
==========================================
+ Hits        43423    43495      +72     
+ Misses       2894     2885       -9     
Impacted Files Coverage Δ
src/fastfield/mod.rs 99.71% <ø> (ø)
src/indexer/sorted_doc_id_multivalue_column.rs 95.00% <94.44%> (-0.46%) ⬇️
src/fastfield/multivalued/mod.rs 98.45% <100.00%> (+1.22%) ⬆️
src/fastfield/multivalued/writer.rs 98.34% <100.00%> (-0.03%) ⬇️
src/fastfield/serializer/mod.rs 100.00% <100.00%> (ø)
src/indexer/merger.rs 98.82% <100.00%> (-0.01%) ⬇️
src/fieldnorm/writer.rs 96.96% <0.00%> (-1.52%) ⬇️
src/directory/mmap_directory.rs 89.86% <0.00%> (-0.54%) ⬇️
src/fastfield/multivalued/reader.rs 96.42% <0.00%> (+5.35%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PSeitz PSeitz requested a review from fulmicoton October 5, 2022 04:40
@PSeitz PSeitz changed the title disable linear codec for multivalue value index disable linear codec for multivalue value Oct 5, 2022
@PSeitz PSeitz changed the title disable linear codec for multivalue value disable linear codec for multivalue values Oct 5, 2022
PSeitz and others added 3 commits October 5, 2022 19:09
don't materialize index column on merge
use simpler chain() variant
@PSeitz PSeitz merged commit 2063f17 into main Oct 5, 2022
@PSeitz PSeitz deleted the ff_refact branch October 5, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants