Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify getters for sstable metadata #1793

Merged
merged 8 commits into from
Jan 18, 2023
Merged

Conversation

trinity-1686a
Copy link
Contributor

this adds support for limit when ranging over an sstable, and makes a few function read less blocks by leveraging sstable metadata more.

This is ready for review, however I'd like to add tests before merging to make sure no of-by-one slipped in

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Merging #1793 (070efff) into main (25bad78) will decrease coverage by 0.07%.
The diff coverage is 76.40%.

@@            Coverage Diff             @@
##             main    #1793      +/-   ##
==========================================
- Coverage   94.18%   94.10%   -0.08%     
==========================================
  Files         271      275       +4     
  Lines       51720    51954     +234     
==========================================
+ Hits        48714    48893     +179     
- Misses       3006     3061      +55     
Impacted Files Coverage Δ
sstable/src/streamer.rs 97.31% <33.33%> (-2.69%) ⬇️
sstable/src/dictionary.rs 72.72% <67.30%> (-2.95%) ⬇️
sstable/src/sstable_index.rs 100.00% <100.00%> (ø)
src/aggregation/agg_result.rs 75.00% <0.00%> (-1.93%) ⬇️
src/aggregation/agg_req.rs 94.03% <0.00%> (-1.21%) ⬇️
src/aggregation/intermediate_agg_result.rs 97.75% <0.00%> (-0.69%) ⬇️
src/aggregation/metric/stats.rs 96.99% <0.00%> (-0.24%) ⬇️
fastfield_codecs/src/null_index/sparse.rs 95.27% <0.00%> (-0.19%) ⬇️
src/schema/schema.rs 98.78% <0.00%> (-0.14%) ⬇️
src/aggregation/bucket/histogram/histogram.rs 99.56% <0.00%> (-0.01%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@guilload guilload requested a review from fulmicoton January 16, 2023 17:27
and fix some bugs they uncovered
@trinity-1686a trinity-1686a merged commit d72ea7d into main Jan 18, 2023
@trinity-1686a trinity-1686a deleted the sstable-ord-random-access branch January 18, 2023 13:42
Hodkinson pushed a commit to Hodkinson/tantivy that referenced this pull request Jan 30, 2023
* add way to get up to `limit` terms from sstable

* make some function of sstable load less data

* add some tests to sstable

* add tests on sstable dictionary

* fix some bugs with sstable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants