-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify getters for sstable metadata #1793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1793 +/- ##
==========================================
- Coverage 94.18% 94.10% -0.08%
==========================================
Files 271 275 +4
Lines 51720 51954 +234
==========================================
+ Hits 48714 48893 +179
- Misses 3006 3061 +55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fulmicoton
reviewed
Jan 17, 2023
fulmicoton
reviewed
Jan 17, 2023
fulmicoton
reviewed
Jan 17, 2023
fulmicoton
reviewed
Jan 17, 2023
fulmicoton
reviewed
Jan 17, 2023
fulmicoton
reviewed
Jan 17, 2023
fulmicoton
reviewed
Jan 17, 2023
fulmicoton
approved these changes
Jan 18, 2023
and fix some bugs they uncovered
Hodkinson
pushed a commit
to Hodkinson/tantivy
that referenced
this pull request
Jan 30, 2023
* add way to get up to `limit` terms from sstable * make some function of sstable load less data * add some tests to sstable * add tests on sstable dictionary * fix some bugs with sstable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds support for limit when ranging over an sstable, and makes a few function read less blocks by leveraging sstable metadata more.
This is ready for review, however I'd like to add tests before merging to make sure no of-by-one slipped in